feat: In app pdf viewer (WPB-28358) - #5235
Draft
ohassine wants to merge 5 commits into
Draft
Conversation
Ups 🫰🟨This PR is too big. Please try to break it up into smaller PRs. |
![semgrep-code-wireapp[bot]](https://avatars.githubusercontent.com/u/16047324?s=60&v=4){kind=small}
|
|
||
| val partial = File(target.parentFile, "${target.name}$PARTIAL_SUFFIX") | ||
| return runCatching { | ||
| val connection = (URL(contentUrl).openConnection() as HttpURLConnection).apply { |
There was a problem hiding this comment.
Server-Side Request Forgery occur when a web server executes a request to a user supplied
destination parameter that is not validated. Such vulnerabilities could allow an attacker to
access internal services or to launch attacks from your web server.
🎉 Fixed in commit 88cdf32 🎉
ohassine
marked this pull request as draft
August 31, 2026 15:19
Contributor
Test Results516 tests 514 ✅ 30s ⏱️ For more details on these failures, see this check. Results for commit 81570de. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-28358
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Implement an in-app PDF viewer on Android so users can open and view PDF files directly within the app without relying on an external PDF reader
Screen_recording_20260831_111258.mp4
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.